fix: allow RESTAPIVersionReleasesCache to retain existing cache on fa…

…ilure #543

pfSense-pkg-RESTAPI/files/usr/local/pkg/RESTAPI/Caches/RESTAPIVersionReleasesCache.inc

@@ -21,9 +21,11 @@ class RESTAPIVersionReleasesCache extends Cache {
      * Retrieves available release information from external repos and updates the releases cache files.
      */
     public function get_data_to_cache(): array {
-        # TODO: Change this to use PHP curl instead of a shell command
-        $fetch_releases_cmd = 'curl -s ' . self::RELEASES_URL . " -m $this->timeout";
-        $releases_json = new Command($fetch_releases_cmd);
-        return json_decode($releases_json->output, true);
+        # Retrieve the available releases from the GitHub API
+        $releases_json = \RESTAPI\Core\Tools\http_request(url: self::RELEASES_URL, method: 'GET');
+        $releases = json_decode($releases_json, true);
+
+        # Return the fetched releases if in a valid format, otherwise retain the existing cache
+        return is_array($releases) ? $releases : $this->read();
     }
 }