cleanup arrays if the last value, which is not undefined, gets removed from it #3406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: dcc63d9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Someone is attempting to deploy a commit to the Formium Team on Vercel. A member of the Team first needs to authorize it. |
gets removed from it
giggo1604
force-pushed
the
fix-arrays-not-getting-cleanup-properly
branch
from
d7033d5
to
dcc63d9
Compare
|
@jaredpalmer @johnrom any chance to get this process going? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an error where you can get to an invalid error state if you remove an array field which has a corresponding error.
Here is a basic example of the original problem: https://codesandbox.io/s/formik-example-forked-gi0kc?file=/index.js
If the empty field gets removed the form will not turn valid because the array is not "empty" and therefore gets not removed from the parent object.
An other way to to fix this might be to rewrite the
isEmptyArrayassertion to also consider arrays with onlyundefinedvalues as empty.