Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve e2e and GitHub Actions caching #3805

Merged
merged 20 commits into from
May 28, 2023
Merged

Improve e2e and GitHub Actions caching #3805

merged 20 commits into from
May 28, 2023

Conversation

jaredpalmer
Copy link
Owner

@jaredpalmer jaredpalmer commented May 28, 2023

  • Bump all of GitHub Actions to v3 like checkout and setup node etc.
  • Switch to using Node 18.x LTS in all CI
  • Fix e2e test app react hydration error by using a ref for the render counter
  • Fix up Playwright tests to use .locator().blur()
  • Change the start:app script to no longer link react package
  • Clean up build scripts to only build packages when needed (not the docs)

In another PR, we will upgrade formik to use React 18.x and bump @testing-library/react and the e2e test to use App Router

@changeset-bot
Copy link

changeset-bot bot commented May 28, 2023

⚠️ No Changeset found

Latest commit: 9d0ea4c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented May 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
formik-docs ⬜️ Ignored (Inspect) Visit Preview May 28, 2023 10:14pm

@jaredpalmer jaredpalmer changed the title Update GH Actions Bump GitHub Actions May 28, 2023
@codesandbox-ci
Copy link

codesandbox-ci bot commented May 28, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9d0ea4c:

Sandbox Source
Formik TypeScript Playground Configuration

@jaredpalmer jaredpalmer changed the title Bump GitHub Actions Bump GitHub Actions, use Node 18.x in CI May 28, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 28, 2023

Size Change: 0 B

Total Size: 40.5 kB

ℹ️ View Unchanged
Filename Size
packages/formik-native/dist/formik-native.cjs.development.js 306 B
packages/formik-native/dist/formik-native.cjs.production.min.js 242 B
packages/formik-native/dist/formik-native.esm.js 238 B
packages/formik-native/dist/index.js 150 B
packages/formik/dist/formik.cjs.development.js 16.2 kB
packages/formik/dist/formik.cjs.production.min.js 7.06 kB
packages/formik/dist/formik.esm.js 16.1 kB
packages/formik/dist/index.js 143 B

compressed-size-action

@jaredpalmer jaredpalmer changed the title Bump GitHub Actions, use Node 18.x in CI Bump GitHub Actions, use Node 18.x, React 18 May 28, 2023
@jaredpalmer jaredpalmer changed the title Bump GitHub Actions, use Node 18.x, React 18 Bump GitHub Actions, use Node 18.x, React 18 for e2e May 28, 2023
@jaredpalmer jaredpalmer changed the title Bump GitHub Actions, use Node 18.x, React 18 for e2e Bump GitHub Actions, use Node 18.x May 28, 2023
@jaredpalmer jaredpalmer changed the title Bump GitHub Actions, use Node 18.x Improve e2e and GitHub Actions caching May 28, 2023
@jaredpalmer jaredpalmer merged commit 4fcf01c into main May 28, 2023
@jaredpalmer jaredpalmer deleted the jp/update-actions branch May 28, 2023 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant