Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#378 Alter touched and error if FA.remove and FA.pop #396

Merged
merged 2 commits into from
Feb 1, 2018

Conversation

jaredpalmer
Copy link
Owner

This solves #378 .

tl;dr
When either pop() or remove() is called, the related partial object within errors and touched are also removed. I also added proper generics (which somehow no one noticed) 🤷‍♀️

@jaredpalmer jaredpalmer merged commit 606f830 into master Feb 1, 2018
@a-tarasyuk
Copy link
Contributor

@jaredpalmer Does it mean that when we remove/push item, setState will be called 3 times(also render fires 3 times)? Maybe would be better to have one method which will update 3 fields and call setState only once? What do you think? Does it make sense?

@jaredpalmer jaredpalmer deleted the fieldArrayErrors branch December 12, 2019 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants