Add keyPrefix to mDel, mGet and ttl, Change clusterStore options type to include customOptions and readd cluster tests #765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change clusterStore options type to include customOptions to allow for keyPrefix in intellisense
Add tests for keyPrefix coverage
Readd the already existing cluster tests file: use {} to avoid CROSSSLOT errors and change the compose file to create a single node cluster for the sake of testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed keyPrefix for ttl and for keyPrefix to be available in my editor's type hints when using clusterStore.
What I fixed is listed below, but if you can help me get just those changes out, I'd be grateful (also @jaredwray let me know if you'd like me to submit a smaller PR with just those few changes if this is too much or not).
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Add keyPrefix to mDel, mGet and ttl
Change clusterStore options type to include customOptions to allow for keyPrefix in intellisense Add tests for keyPrefix coverage
Readd the already existing cluster tests file (it didn't get to run before): use {} to avoid CROSSSLOT errors and change the compose file to create a single node cluster for the sake of testing