Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node-cache - upgrading typescript to 5.6.2 #778

Merged
merged 3 commits into from
Sep 15, 2024

Conversation

jaredwray
Copy link
Owner

@jaredwray jaredwray commented Sep 15, 2024

Please check if the PR fulfills these requirements

  • Followed the Contributing guidelines.
  • Tests for the changes have been added (for bug fixes/features) with 100% code coverage.
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
node-cache - upgrading typescript to 5.6.2

Copy link

codecov bot commented Sep 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (cf3e5b6) to head (20cf6f6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #778   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines           47        47           
=========================================
  Hits            47        47           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jaredwray jaredwray merged commit 09652cb into main Sep 15, 2024
7 checks passed
@jaredwray jaredwray deleted the node-cache---upgrading-typescript-to-5.6.2 branch September 15, 2024 19:46
@jaredwray jaredwray mentioned this pull request Sep 15, 2024
5 tasks
@rbnayax
Copy link

rbnayax commented Sep 16, 2024

@jaredwray when can we expect a new version with those changes?
Can't upgrade TS version until it gets released

@jaredwray
Copy link
Owner Author

@rbnayax - this was released with v0.8.0 and is available on npm. Is there an error you are getting?

@rbnayax
Copy link

rbnayax commented Sep 22, 2024

https://www.npmjs.com/package/cache-manager?activeTab=code shows that it still uses v10 of lru cache

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants