Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If sshfs is not installed, missing util is flashed for a second. More helpful error message is required. #739

Closed
thexavier666 opened this issue Sep 24, 2020 · 2 comments
Labels

Comments

@thexavier666
Copy link

Environment details (Put x in the checkbox along with the information)

[x] Operating System: xubuntu 20.04
[x] Desktop Environment: i3
[x] Terminal Emulator: alacritty
[x] Shell: zsh
[ ] Custom desktop opener (if applicable):
[ ] Program options used:
[ ] Configuration options set:
[x] Issue exists on nnn master: v3.4

Exact steps to reproduce the issue

In a fresh install of xubuntu, sshfs is not installed. So the remote mount feature is not working.
Can a better error be shown, such as "Please install sshfs to mount remote directory", instead of "missing util"?

@jarun
Copy link
Owner

jarun commented Sep 24, 2020

It's a common message for any missing deps. We do not want to mention what utility is missing because the workflows tell that (e.g. in this case sshfs) and it saves some bytes in the binary. When you see this, please visit the relevant Wiki section: https://github.com/jarun/nnn/wiki/Usage#dependencies

@jarun jarun closed this as completed Sep 24, 2020
jarun added a commit that referenced this issue Oct 10, 2020
@jarun
Copy link
Owner

jarun commented Oct 10, 2020

We have another issue on this now so I have added the patch to show the name of the utility.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants