-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for older node versions #60
Conversation
What older versions did you test with? |
I tested with |
What about Also |
We could support older versions if needed, but this PR is specially to unblock expressjs/body-parser#233 |
Sounds like the version check shouldn't be removed then; it should just be lowered to allow 0.7? |
Reasonable ask. Updated the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems legit 👍
it'd still be good to get things working on 0.4 and 0.6 tho :-)
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "nvs", | |||
"version": "1.3.0", | |||
"version": "1.3.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
altho actually, this is semver-minor imo, not patch, and generally version numbers should never be bumped in PRs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose in a project that is often cherry-picking changes across multiple major-version branches/releases, then you wouldn't want the changes to include version numbers. But this project isn't that complex, so it doesn't matter to me.
As for semver-minor vs patch, I think it could go either way. So, this is fine.
That only goes down to version 0.8. So why go to 0.7 here (and not 0.6)? |
Not particular reason. I just found out that upto |
Removed condition that was prohibiting NVS using for node versions older than
0.10
. Bumped the version to1.3.1
.