Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for older node versions #60

Merged
merged 3 commits into from
Jul 3, 2017

Conversation

kunalspathak
Copy link
Contributor

Removed condition that was prohibiting NVS using for node versions older than 0.10. Bumped the version to 1.3.1.

@jasongin
Copy link
Owner

What older versions did you test with?

@kunalspathak
Copy link
Contributor Author

I tested with 0.7, 0.8 and 0.9. It doesn't work with 0.1, 0.2, 0.3, 0.4, 0.5 because of missing files in index.json. Didn't bother finding why they failed.

@ljharb
Copy link
Contributor

ljharb commented Jun 29, 2017

What about 0.6? 0.7 and 0.9 and 0.3 and 0.5 and 0.1 aren't important because they're unstable by the apache model, but 0.6 and 0.8 are stable.

Also 0.4 would be nice but isn't quite as important.

@kunalspathak
Copy link
Contributor Author

We could support older versions if needed, but this PR is specially to unblock expressjs/body-parser#233

@ljharb
Copy link
Contributor

ljharb commented Jun 29, 2017

Sounds like the version check shouldn't be removed then; it should just be lowered to allow 0.7?

@kunalspathak
Copy link
Contributor Author

Reasonable ask. Updated the PR.

Copy link
Contributor

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit 👍

it'd still be good to get things working on 0.4 and 0.6 tho :-)

@@ -1,6 +1,6 @@
{
"name": "nvs",
"version": "1.3.0",
"version": "1.3.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

altho actually, this is semver-minor imo, not patch, and generally version numbers should never be bumped in PRs

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose in a project that is often cherry-picking changes across multiple major-version branches/releases, then you wouldn't want the changes to include version numbers. But this project isn't that complex, so it doesn't matter to me.

As for semver-minor vs patch, I think it could go either way. So, this is fine.

@jasongin
Copy link
Owner

jasongin commented Jun 29, 2017

We could support older versions if needed, but this PR is specially to unblock expressjs/body-parser#233

That only goes down to version 0.8. So why go to 0.7 here (and not 0.6)?

@kunalspathak
Copy link
Contributor Author

So why go to 0.7 here (and not 0.6)?

Not particular reason. I just found out that upto 0.7 gets supported with minimal changes needed. (just regex change). Supporting older version would need changes at multiple places and hence didn't add support for them.

@jasongin jasongin merged commit 8bbf576 into jasongin:master Jul 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants