Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a minimal example and CodeSandbox demo to README #193

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gotchane
Copy link

@gotchane gotchane commented Nov 9, 2018

Hi @jasonkuhrt, thanks to mainteining this project! It is so useful for me.
Let me send a PR about improving README.

When I read the issues such as #170 or #175, I had the same impression about the documentation of this project because I was also a newbie of using react-popover.

So I tryed to add a minimal example and CodeSandbox demo to README to make it easier to understand about react-popover.

Any comments are welcome.

@gotchane
Copy link
Author

gotchane commented Nov 9, 2018

Sorry, it is the first time to use Prettier CI..
Let me ask about how to use it.

I try to build Prettier CI on my forked repository, This PR created.
gotchane#1

Is it necessary to merge the PR created by Prettier CI to my PR target branch gotchane:add-example-to-readme ?

@MaggiWuerze
Copy link

this helped me a lot when getting started

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants