Add Mac M1 support to build.py. #6782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Mac M1, use Bazel 4.1.0rc4. (We'd use the released version of Bazel 4.1.0 if it existed yet.) The newer Bazel version seems sufficient to get a working build, modulo the usual kinks.
Together with a small fix to the LLVM build file that I will submit separately via the TF tree, this is enough to build jaxlib on Mac M1 and for most jax tests to pass. (
34/11217 tests fail when running. edit: with another 1-line fix to XLA, we are down to 2 test failures, both of which are numerical.)pytest -n auto tests, apparently with segfaults of various kinds, which is not bad for a first versionIssue #5501