Collect more disk information #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is on top of #63 |
|
@jpo-joyent Hi! I've already merged #63 so would you mind rebasing to master and re-pushing to this PR? That would remove the udevInfo() code that is contained in here. |
jaypipes
requested changes
Oct 2, 2018
There was a problem hiding this comment.
@jpo-joyent love most of these changes, thank you! :) I've left a couple suggestions for you to change if that's OK with you? Lemme know if you need assistance with the git rebase thing..
-jay
lsblk uses the same logic for determining WWN, namely: - try to get ID_WWN_WITH_EXTENSION from udev - if that fails, try to get ID_WWN See: - util-linux/util-linux#321 - util-linux/util-linux@4d7ef26
`WorldWideName` => `WWN` `NumaNodeId` => `NUMANodeID`
|
Suggestions applied. Thanks! |
|
Awesome, thanks so much @jpo-joyent! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds code to also collect:
Also fixes a bug where serial numbers would be listed as #unknown instead of being omitted
One downside is we re-read and re-parse the udev db (a small flat file) for each property lookup. I could cache it, but it would make the code uglier. Let me know if you'd like me to.
If you need me to break these out into separate PRs, just let me know.