Split device template filter into two extra template filters #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patimatnazhm
changed the title
Bouke
requested changes
Jul 6, 2021
| @@ -1,3 +1,4 @@ | |||
| .idea/ | |||
There was a problem hiding this comment.
Please don't include unrelated changes.
There was a problem hiding this comment.
Hint: You can include this in $HOME/.config/git/ignore and it will be ignored on any local repository.
| @register.filter | ||
| def browser(value): | ||
| """ | ||
| Transform a User Agent into human readable text. |
There was a problem hiding this comment.
Having the same docstring for all three filters will be confusing, update the docstring to reflect the return value.
Bouke
requested changes
Jul 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In user_sessions/templatetags/user_sessions.py I added two template filters,
platformandbrowser, which are the splitteddevicetemplate filter.Motivation and Context
We have faced with the necessity to use name of browser and name of platform in different lines of code. So, as a result of the splitting, there's no longer a need to override the template filter for these purposes. I think that two added above-mentioned filters are a frequent need, especially while HTML coding.
Types of changes
Checklist: