Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from setup.py to pyproject.toml #170

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Switch from setup.py to pyproject.toml #170

merged 1 commit into from
Oct 5, 2023

Conversation

WhyNotHugo
Copy link
Member

@WhyNotHugo WhyNotHugo commented Oct 5, 2023

Motivation and Context

This'll make configuring a few tools a bit easier. The previous approach is kinda of deprecated anyway.

How Has This Been Tested?

CI is about to do some more testing. But basically:

mkvirtualenv tmp
pip install -e .

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

This'll make configuring a few tools a bit easier. The previous approach
is kinda of deprecated anyway.
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #170 (a891b20) into master (8ebdfe8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #170   +/-   ##
=======================================
  Coverage   92.62%   92.62%           
=======================================
  Files          16       16           
  Lines         746      746           
  Branches       50       50           
=======================================
  Hits          691      691           
  Misses         45       45           
  Partials       10       10           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@WhyNotHugo WhyNotHugo marked this pull request as ready for review October 5, 2023 14:35
@WhyNotHugo WhyNotHugo requested a review from blag October 5, 2023 14:36
Copy link
Contributor

@blag blag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Once this is merged let's add an issue to cleanup dev dependencies a bit. Some of them appear to be out of date, or are no longer required.

Comment on lines +54 to +55
"tox-pyenv",
"detox",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still needed?

@blag blag merged commit 5b1713d into master Oct 5, 2023
34 of 35 checks passed
@blag blag deleted the pyproject.toml branch October 5, 2023 22:50
WhyNotHugo added a commit that referenced this pull request Oct 5, 2023
This was accidentally not included in #170
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants