Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some cleanup #1068

Merged
merged 3 commits into from
Feb 15, 2020
Merged

Some cleanup #1068

merged 3 commits into from
Feb 15, 2020

Conversation

richafrank
Copy link
Contributor

Some cleanup that was pulled out of a no-longer-useful branch I had been working on:

  • Fixed a docstring
  • Standardized on key_from_ireq for use with InstallRequirements. It had been a mix of key_from_ireq(ireq) and key_from_req(ireq.req).
  • Ensured that a finally block can run even if NamedTemporaryFile construction raises

Changelog-friendly one-liner: Minor cleanup, including standardizing on key_from_ireq

Copy link
Member

@atugushev atugushev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much! Reading my mind 😉

@codecov
Copy link

codecov bot commented Feb 14, 2020

Codecov Report

Merging #1068 into master will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1068      +/-   ##
==========================================
+ Coverage   99.26%   99.34%   +0.08%     
==========================================
  Files          34       34              
  Lines        2446     2446              
  Branches      306      306              
==========================================
+ Hits         2428     2430       +2     
+ Misses         10        8       -2     
  Partials        8        8              
Impacted Files Coverage Δ
piptools/repositories/pypi.py 93.65% <0.00%> (+0.97%) ⬆️
piptools/utils.py 100.00% <0.00%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d405bf9...6be629d. Read the comment docs.

@atugushev atugushev merged commit f2e2e2b into jazzband:master Feb 15, 2020
@richafrank richafrank deleted the some-cleanup branch February 15, 2020 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants