Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flake8 ignore E203; see https://github.com/psf/black#slices #1081

Merged
merged 1 commit into from
Feb 29, 2020

Conversation

AndydeCleyre
Copy link
Contributor

As requested in review for #1080, have flake8 consistently ignore any E203 occurrences.

Changelog-friendly one-liner: Not applicable, I think.

Contributor checklist
  • Provided the tests for the changes.
  • Gave a clear one-line description in the PR (that the maintainers can add to CHANGELOG.md on release).
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

Copy link
Member

@atugushev atugushev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment could be removed now

(tup + (False, set())[len(tup) - 2 :]) # noqa: E203

setup.cfg Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Feb 29, 2020

Codecov Report

Merging #1081 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1081   +/-   ##
=======================================
  Coverage   99.51%   99.51%           
=======================================
  Files          34       34           
  Lines        2478     2478           
  Branches      312      312           
=======================================
  Hits         2466     2466           
  Misses          6        6           
  Partials        6        6           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a58a1c5...06a1bd9. Read the comment docs.

@AndydeCleyre
Copy link
Contributor Author

This comment could be removed now

Nice, removed.

Copy link
Member

@atugushev atugushev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@atugushev atugushev merged commit b17c9d8 into jazzband:master Feb 29, 2020
@atugushev
Copy link
Member

@AndydeCleyre thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants