Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore local hashes with --no-reuse-hashes #1177

Merged

Conversation

graingert
Copy link
Member

@graingert graingert commented Jul 9, 2020

Fixes #1176

Changelog-friendly one-liner: Ignore local hashes with --no-reuse-hashes in pip-compile

Contributor checklist
  • Provided the tests for the changes.
  • Gave a clear one-line description in the PR (that the maintainers can add to CHANGELOG.md on release).
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

@graingert graingert force-pushed the ignore-local-hashes-with-no-reuse-hashes branch from 3c28e34 to 6c13f1c Compare July 9, 2020 14:26
@codecov
Copy link

codecov bot commented Jul 9, 2020

Codecov Report

Merging #1177 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1177   +/-   ##
=======================================
  Coverage   99.50%   99.50%           
=======================================
  Files          36       36           
  Lines        2841     2852   +11     
  Branches      334      335    +1     
=======================================
+ Hits         2827     2838   +11     
  Misses          8        8           
  Partials        6        6           
Impacted Files Coverage Δ
piptools/repositories/local.py 96.36% <100.00%> (ø)
piptools/scripts/compile.py 100.00% <100.00%> (ø)
tests/test_repository_local.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7db32a...fd17c36. Read the comment docs.

@graingert
Copy link
Member Author

#1176

@atugushev atugushev changed the title ignore local hashes with --no-reuse-hashes Fixes #1176 Ignore local hashes with --no-reuse-hashes Jul 18, 2020
@atugushev atugushev added enhancement Improvements to functionality cli Related to command line interface things labels Jul 18, 2020
Copy link
Member

@atugushev atugushev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@graingert
Copy link
Member Author

@atugushev do I need to get a review from another maintainer?

@atugushev
Copy link
Member

@graingert one approval is enough 👍 I'm going to prepare a release soon, right before pip-20.2 will be released.

@atugushev atugushev added this to the 5.3.0 milestone Jul 20, 2020
@atugushev atugushev merged commit 9eb10d7 into jazzband:master Jul 20, 2020
@graingert graingert deleted the ignore-local-hashes-with-no-reuse-hashes branch July 20, 2020 12:34
@atugushev
Copy link
Member

pip-tools v5.3.0 is released.

@graingert
Copy link
Member Author

@atugushev amazing, thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Related to command line interface things enhancement Improvements to functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ignore current hashes using --no-reuse-hashes
2 participants