fix failing tox tests #1405
Merged
fix failing tox tests #1405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd using newest feature in new version
Codecov Report
@@ Coverage Diff @@
## master #1405 +/- ##
=======================================
Coverage 99.67% 99.67%
=======================================
Files 33 34 +1
Lines 3038 3040 +2
Branches 327 327
=======================================
+ Hits 3028 3030 +2
Misses 5 5
Partials 5 5
Continue to review full report at Codecov.
|
nicoa
commented
May 28, 2021
tox.ini
Outdated
| pipprevious: pip==20.3.* | ||
| piplatest: pip | ||
| pipmain: -e git+https://github.com/pypa/pip.git@main#egg=pip | ||
| pip20.3: pip==20.3.* | ||
| setenv = | ||
| coverage: PYTEST_ADDOPTS=--strict --doctest-modules --cov --cov-report=term-missing --cov-report=xml {env:PYTEST_ADDOPTS:} | ||
| pipprevious,pip20.3: PIP_DISABLE_PIP_VERSION_CHECK=1 |
There was a problem hiding this comment.
those are probably not necessary - should we still use them anyways (at least the feature flag)?
webknjaz
reviewed
May 29, 2021
| @@ -11,12 +11,15 @@ extras = | |||
| testing | |||
| coverage: coverage | |||
| deps = | |||
| setuptools<57 | |||
There was a problem hiding this comment.
This requires a comment explaining the motivation
webknjaz
reviewed
May 29, 2021
ssbarnea
approved these changes
Jun 1, 2021
webknjaz
approved these changes
Jun 1, 2021
atugushev
added
skip-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1403 .
Changelog-friendly one-liner: fix failing tox tests by pinning setuptools to old version and disabling pip version check on old version and using new feature "in-tree-build" in new version
Contributor checklist