Introduce a gate/check GHA job #1682
Conversation
webknjaz
added
tests
|
CI is not happy due to:
@jezdez could you please approve re-actors/alls-green and update settings accordingly? Also, the |
|
@atugushev I've added re-actors/alls-green to the list of approved actions, but can't add the "check" run as the only required one since it hasn't run yet. Once this PR passes and it runs, I'll add it to the settings. |
|
@jezdez so did it appear in the project settings? |
This adds a GHA job that reliably determines if all the required dependencies have succeeded or not. It also allows to reduce the list of required branch protection CI statuses to just one — `check`. This reduces the maintenance burden by a lot and have been battle-tested across a small bunch of projects in its action form and in-house implementations of other people. It is now in use in aiohttp (and other aio-libs projects), CherryPy, some of the Ansible repositories, all of the jaraco's projects (like `setuptools`, `importlib_metadata`), some PyCQA, PyPA, PyCA and pytest projects, a few AWS Labs projects. Admittedly, I maintain a few of these but it seems to address some of the pain folks have: jaraco/skeleton#55 (comment). The story behind this is explained in more detail at https://github.com/marketplace/actions/alls-green#why.
webknjaz
force-pushed
the
maintenance/gha-check
branch
from
2cf0e8c
to
7f90005
Compare
|
I've applied formatting per pre-commit's requirements, amended the commit and rebased it on top of the current master. This should make all the checks green. |
|
The check run appeared now in the branch protection settings, I've enabled it. |
Note that this will block other/new PRs for as long as this one is unmerged. All of the PRs will need CI to be retriggered. |
|
I've enabled the auto-merge to shorten the period of this race condition, at least for the new PRs. |
This adds a GHA job that reliably determines if all the required dependencies have succeeded or not.
It also allows to reduce the list of required branch protection CI statuses to just one —
check. This reduces the maintenance burden by a lot and have been battle-tested across a small bunch of projects in its action form and in-house implementations of other people.It is now in use in aiohttp (and other aio-libs projects), CherryPy, some of the Ansible repositories, all of the jaraco's projects (like
setuptools,importlib_metadata), some PyCQA, PyCA and pytest projects, a few AWS Labs projects. Admittedly, I maintain a few of these but it seems to address some of the pain folks have: jaraco/skeleton#55 (comment).The story behind this is explained in more detail at https://github.com/marketplace/actions/alls-green#why.
Contributor checklist
Maintainer checklist
backwards incompatible,feature,enhancement,deprecation,bug,dependency,docsorskip-changelogas they determine changelog listing.