Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for sync error when the ireqs being merged have no names #1802

Merged
merged 2 commits into from
Feb 2, 2023

Conversation

richafrank
Copy link
Contributor

@richafrank richafrank commented Jan 19, 2023

When no name was provided, the ireqs would have no underlying req attribute. Calling ireq.specifier while comparing them in merge, would raise an AttributeError.

Fixes #1710

Contributor checklist
  • Provided the tests for the changes.
  • Assure PR title is short, clear, and good to be included in the user-oriented changelog
Maintainer checklist
  • Assure one of these labels is present: backwards incompatible, feature, enhancement, deprecation, bug, dependency, docs or skip-changelog as they determine changelog listing.
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

Copy link
Member

@atugushev atugushev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍🏻 Mabe an integrational test in test_cli_sync.py instead of the unit or keep both.

When no name was provided, the ireqs would have no underlying req
attribute. Calling ireq.specifier would raise an AttributeError.
@atugushev atugushev merged commit 9134115 into jazzband:main Feb 2, 2023
@richafrank richafrank deleted the sync-error-no-specifier branch February 2, 2023 16:04
@atugushev atugushev added this to the 6.12.3 milestone Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pip-sync errors when merging multiple requirements.txt files that point at the same editable install
3 participants