Recalculate secondary dependencies between rounds #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously dependency constrains were only added between rounds of resolving dependencies. This could cause irrelevant packages to be present in resulting requirements.txt, e.g. when collecting third-level dependencies (celery->amqp->vine), when second-level dependency changes (ampq 2.0.2 -> 1.4.9), 3rd-level requirement (vine) might remain in resulting output. So instead of adding new constrains each round and stopping when there was nothing to add, we replace old constrains with newlely calculated ones each round and stop when both sets of constrains are identical. fixes jazzband#370
|
@nvie any thoughts how we should improve this code to get PR merged? |
|
Looking forward to this feature 👍 |
|
Thanks, this feature is awesome, and sorry I have not merged this before, @coagulant ! |
suutari-ai
added a commit
to suutari/prequ
that referenced
this pull request
Feb 9, 2017
Mark the merged PRs of pip-tools in Change Log more clearly so that it is easier to keep track which fixes/features are already in. This includes following 7 PRs: * jazzband#355 * jazzband#378 * jazzband#389 * jazzband#417 * jazzband#441 * jazzband#448 * jazzband#450
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously dependency constrains were only added between rounds of
resolving dependencies.
This could cause irrelevant packages to be
present in resulting requirements.txt, e.g. when collecting third-level
dependencies (celery->amqp->vine), when second-level
dependency changes (ampq 2.0.2 -> 1.4.9), 3rd-level requirement (vine)
might remain in resulting output.
So instead of adding new constrains each round and stopping when
there was nothing to add, we replace old constrains with newlely calculated ones
each round and stop when both sets of constrains are identical.
fixes #370