Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support pip 19.0 #715

Merged
merged 1 commit into from
Jan 23, 2019
Merged

Support pip 19.0 #715

merged 1 commit into from
Jan 23, 2019

Conversation

atugushev
Copy link
Member

@atugushev atugushev commented Jan 22, 2019

Changelog-friendly one-liner: Support pip 19.0

Contributor checklist
  • Provided the tests for the changes
  • Requested (or received) a review from another contributor
  • Gave a clear one-line description in the PR (that the maintainers can add to CHANGELOG.md afterwards).

@codecov
Copy link

codecov bot commented Jan 22, 2019

Codecov Report

Merging #715 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #715      +/-   ##
==========================================
+ Coverage   85.13%   85.17%   +0.03%     
==========================================
  Files          31       31              
  Lines        2059     2064       +5     
  Branches      308      309       +1     
==========================================
+ Hits         1753     1758       +5     
  Misses        235      235              
  Partials       71       71
Impacted Files Coverage Δ
tests/test_cli.py 97.86% <100%> (ø) ⬆️
piptools/repositories/pypi.py 89.37% <100%> (+0.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e03ce4f...5029fcc. Read the comment docs.

Copy link
Member

@vphilippon vphilippon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment about retrocompatibility, nothing too major to fix I think.

Thanks for your contribution, I've seen your activity lately, and I really appreciate it as I lack the time to properly respond or contribute.

I'll try to keep an eye on this, and get a release out as ASAP afterwards.

piptools/repositories/pypi.py Show resolved Hide resolved
@vphilippon vphilippon added this to the 3.3.0 milestone Jan 23, 2019
@vphilippon vphilippon merged commit e41456d into jazzband:master Jan 23, 2019
@atugushev atugushev deleted the support-pip-19.0 branch January 25, 2019 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pip-compile broken with pip 19.0
2 participants