Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pip-sync to use pip script depending on a python version #737

Merged
merged 1 commit into from
Feb 19, 2019

Conversation

atugushev
Copy link
Member

Fixes #734.

Changelog-friendly one-liner: Fix pip-sync to use pip script depending on a python version

Contributor checklist
  • Provided the tests for the changes.
  • Requested a review from another contributor.
  • Gave a clear one-line description in the PR (that the maintainers can add to CHANGELOG.md on release).
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

@atugushev atugushev added this to the 3.4.0 milestone Feb 15, 2019
piptools/sync.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Feb 16, 2019

Codecov Report

Merging #737 into master will increase coverage by 0.15%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #737      +/-   ##
==========================================
+ Coverage   85.81%   85.96%   +0.15%     
==========================================
  Files          31       31              
  Lines        2122     2124       +2     
  Branches      305      304       -1     
==========================================
+ Hits         1821     1826       +5     
+ Misses        233      232       -1     
+ Partials       68       66       -2
Impacted Files Coverage Δ
tests/test_sync.py 98.44% <100%> (+0.06%) ⬆️
piptools/sync.py 81.91% <100%> (+2.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ede4c62...18d05c0. Read the comment docs.

Copy link
Contributor

@blueyed blueyed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Copy link
Member

@vphilippon vphilippon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
(Please keep them coming!)

@vphilippon vphilippon merged commit 938176b into jazzband:master Feb 19, 2019
@kb-1000
Copy link

kb-1000 commented Feb 19, 2019

Awesome, this even fixes another issue I had (importing piptools and running it inside another script)!

@kb-1000
Copy link

kb-1000 commented Feb 19, 2019

When can I expect a release including this fix?

@vphilippon
Copy link
Member

@kaeptmblaubaer1000 I'm preparing a release right now. Taking the CI time into account, in the next few hours.

@vphilippon
Copy link
Member

pip-tools v3.4.0 released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants