Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatibility with pip==19.3 for removed Link.is_artifact property #904

Merged

Conversation

atugushev
Copy link
Member

@atugushev atugushev commented Sep 21, 2019

Remove Link.is_artifact usage in favour of is_vcs_url.

See pypa/pip#7059

Changelog-friendly one-liner: Add compatibility with pip==19.3.

Contributor checklist
  • Provided the tests for the changes.
  • Requested a review from another contributor.
  • Gave a clear one-line description in the PR (that the maintainers can add to CHANGELOG.md on release).
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

@atugushev atugushev modified the milestones: 4.1.1, 4.2.0 Sep 21, 2019
@atugushev atugushev changed the title Add compatibility with pip==19.3 Add compatibility with pip==19.3 for removed Link.is_artifact property Sep 21, 2019
@codecov
Copy link

codecov bot commented Sep 22, 2019

Codecov Report

Merging #904 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #904   +/-   ##
=======================================
  Coverage   99.06%   99.06%           
=======================================
  Files          35       35           
  Lines        2247     2247           
  Branches      288      288           
=======================================
  Hits         2226     2226           
  Misses         13       13           
  Partials        8        8
Impacted Files Coverage Δ
piptools/repositories/pypi.py 95.12% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53c0742...8becc9d. Read the comment docs.

Copy link
Member

@codingjoe codingjoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be ok, but I have one concern about using the method over the is_vcs property. I am not so fluent in the pip changes though.

piptools/repositories/pypi.py Show resolved Hide resolved
Copy link
Member

@codingjoe codingjoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@atugushev atugushev merged commit df62e46 into jazzband:master Sep 25, 2019
@atugushev atugushev deleted the pip-compat-remove-link-is-artifact branch September 25, 2019 17:07
@atugushev
Copy link
Member Author

Thanks @codingjoe!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants