Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatibility with pip==19.3 for refactored URL helpers #910

Merged

Conversation

atugushev
Copy link
Member

@atugushev atugushev commented Sep 25, 2019

Add compatibility with pip==19.3 for the following changes:

  1. Move some URL-related functions to utils.urls. pypa/pip#7036
  2. Move path_to_url() to utils/urls.py pypa/pip#7075

Changelog-friendly one-liner: Add compatibility with pip==19.3.

Contributor checklist
  • Provided the tests for the changes.
  • Requested a review from another contributor.
  • Gave a clear one-line description in the PR (that the maintainers can add to CHANGELOG.md on release).
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

Function is_file_url() changed to Link.is_file property.
Function is_dir_url() changed to Link.is_existing_dir() method.

See pypa/pip#7036
@atugushev atugushev added this to the 4.2.0 milestone Sep 25, 2019
@atugushev atugushev changed the title Pip 19.3 compat url funcs refactor Add compatibility with pip==19.3 for refactored URL helpers Sep 25, 2019
@atugushev atugushev closed this Sep 25, 2019
@atugushev atugushev reopened this Sep 25, 2019
@codecov
Copy link

codecov bot commented Sep 26, 2019

Codecov Report

Merging #910 into master will increase coverage by 0.48%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #910      +/-   ##
==========================================
+ Coverage   98.57%   99.06%   +0.48%     
==========================================
  Files          35       35              
  Lines        2247     2247              
  Branches      288      288              
==========================================
+ Hits         2215     2226      +11     
+ Misses         21       13       -8     
+ Partials       11        8       -3
Impacted Files Coverage Δ
piptools/utils.py 100% <0%> (+2.04%) ⬆️
piptools/repositories/pypi.py 95.12% <0%> (+3.9%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df62e46...3937caf. Read the comment docs.

Copy link
Member

@codingjoe codingjoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Is there a timeline yet, then the old util functions will be dropped?

@atugushev
Copy link
Member Author

@codingjoe

Thanks for reviewing this! Much appreciated!

Is there a timeline yet, then the old util functions will be dropped?

There is not. It needs to be discussed. Probably it's time to raise an issue.

@atugushev
Copy link
Member Author

@codingjoe

FYI, discussion started here #853.

@atugushev atugushev merged commit 51463fc into jazzband:master Sep 26, 2019
@atugushev atugushev deleted the pip-19.3-compat-url-funcs-refactor branch September 26, 2019 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants