Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix --trusted-host is not copied from *.in to *.txt #964

Merged
merged 3 commits into from
Oct 27, 2019

Conversation

atugushev
Copy link
Member

@atugushev atugushev commented Oct 22, 2019

Fixes #963.

Changelog-friendly one-liner: Fix pip-compile doesn't copy --trusted-host from requirements.in to requirements.txt.

Contributor checklist
  • Provided the tests for the changes.
  • Gave a clear one-line description in the PR (that the maintainers can add to CHANGELOG.md on release).
  • Assign the PR to an existing or new milestone for the target version (following Semantic Versioning).

@atugushev atugushev added this to the 4.3.0 milestone Oct 22, 2019
@codecov
Copy link

codecov bot commented Oct 22, 2019

Codecov Report

Merging #964 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #964      +/-   ##
==========================================
+ Coverage   99.18%   99.19%   +<.01%     
==========================================
  Files          35       35              
  Lines        2338     2358      +20     
  Branches      301      303       +2     
==========================================
+ Hits         2319     2339      +20     
  Misses         11       11              
  Partials        8        8
Impacted Files Coverage Δ
piptools/scripts/compile.py 100% <ø> (ø) ⬆️
piptools/utils.py 100% <100%> (ø) ⬆️
tests/test_utils.py 100% <100%> (ø) ⬆️
tests/test_cli_compile.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 192e957...0c9905f. Read the comment docs.

Copy link

@altendky altendky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked over code and confirmed it works as expected locally.

@altendky
Copy link

Oh yeah... thanks!

piptools/utils.py Outdated Show resolved Hide resolved
piptools/utils.py Outdated Show resolved Hide resolved
atugushev and others added 2 commits October 23, 2019 21:52
Keep consistent the return type.

Co-Authored-By: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
Fix the docstring to be precise.

Co-Authored-By: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
Copy link
Member

@nasirhjafri nasirhjafri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@codingjoe
Copy link
Member

I believe the have been more than enough reviews. So I am going to save myselthe trouble, ok?

@atugushev
Copy link
Member Author

@webknjaz thanks for taking the time reviewing this! All request changes seem resolved, are we okay with this or are there any other issues?

@atugushev atugushev merged commit 4dee581 into jazzband:master Oct 27, 2019
@atugushev atugushev deleted the compile-trusted-host-963 branch October 27, 2019 16:16
@atugushev
Copy link
Member Author

atugushev commented Oct 27, 2019

@webknjaz @nasirhjafri @altendky thanks for reviewing this! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option --trusted-host is not copied from requirements.in to requirements.txt
5 participants