Prevent navigation to directories using file:// protocol in IE

jberd126 · Mar 5, 2019 · 67e2236 · 67e2236
1 parent ef515df
commit 67e2236
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/cpp/iedriver/CommandHandlers/GoToUrlCommandHandler.cpp b/cpp/iedriver/CommandHandlers/GoToUrlCommandHandler.cpp
@@ -56,7 +56,7 @@ void GoToUrlCommandHandler::ExecuteInternal(
       return;
     }
 
-    BOOL is_file_url = ::UrlIsFileUrl(wide_url.c_str());
+    bool is_file_url = ::UrlIsFileUrl(wide_url.c_str()) == TRUE;
     if (is_file_url) {
       DWORD path_length = MAX_PATH;
       std::vector<wchar_t> buffer(path_length);
@@ -73,6 +73,13 @@ void GoToUrlCommandHandler::ExecuteInternal(
                                      "Specified URL (" + url + ") is a file, " +
                                      "but the path was not valid.");
           return;
+        } else {
+          if (::PathIsDirectory(file_path.c_str())) {
+            response->SetErrorResponse(ERROR_INVALID_ARGUMENT,
+                                       "Specified URL (" + url + ") is a directory, " +
+                                       "and the browser opens directories outside the browser window.");
+              return;
+          }
         }
       }
     }