forked from SeleniumHQ/selenium
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fixing incorrect error response format for invalid commands in IE
Previously, when an invalid command was sent to the IE driver, the response was not completely valid for the W3C dialect of the wire protocol. In particular, the distinction was lost between an unknown URL and an invalid HTTP verb, and this code was not properly converted when the driver was updated to implement the specification. This change fixes that. Correct responses are now sent back for both invalid command cases. Additionally, the driver no longer hand-codes JSON for these responses, instead creating a valid Response object, and using the common serialization mechanism for transmission. Finally, this commit includes some minor code formatting cleanup, which does not affect the functionality of the driver. Fixes issue SeleniumHQ#6828.
- Loading branch information
Showing
4 changed files
with
91 additions
and
65 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters