New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backfill tests #4

Closed

8 tasks done

jchesterpivotal opened this issue Aug 18, 2018 · 0 comments

Owner

jchesterpivotal commented Aug 18, 2018 •

edited

Loading

As a Pivot
I want to have tested code
So that I may be received in polite company

Given a codebase which is untested
When I backfill the tests
Then I should feel less guilty

jchesterpivotal pushed a commit that referenced this issue


          Backfill test for build-pass-fail

0ae7490

- Introduce sclevine/spec library

[#4]

Signed-off-by: Jacques Chester <jchester@pivotal.io>

jchesterpivotal pushed a commit that referenced this issue


          Simplify test fixtures

72b9fbe

- Use tabs for fixture indentation

[#4]

Signed-off-by: Jacques Chester <jchester@pivotal.io>

jchesterpivotal pushed a commit that referenced this issue


          Enable build-pass-fail to accept a path as an argument

c0032d1

[#4]

Signed-off-by: Jacques Chester <jchester@pivotal.io>

jchesterpivotal pushed a commit that referenced this issue


          Extract mkdir/rmdir into toplevel before/after

78d895f

[#4]

Signed-off-by: Jacques Chester <jchester@pivotal.io>

jchesterpivotal pushed a commit that referenced this issue


          Use separate fixture JSON files in tests

0be7b64

Previously relied on a build/build.json file which was shared amongst
tests -- a fragile approach that couldn't be parallelised safely.

[#4]

Signed-off-by: Jacques Chester <jchester@pivotal.io>

jchesterpivotal pushed a commit that referenced this issue


          Deglobalise cmd variable

6dab65d

[#4]

Signed-off-by: Jacques Chester <jchester@pivotal.io>

jchesterpivotal pushed a commit that referenced this issue


          Perform suite before/after once, not per-test

fb7b35a

The spec library has a different operation model from Ginkgo. For
one-time before/afters, the logic must sit outside of the spec.Run()
method, not under a it.Before/it.After.

Shows a dramatic speedup, as we are no longer unwittingly recompiling
the command for every single test.

[#4]

Signed-off-by: Jacques Chester <jchester@pivotal.io>

jchesterpivotal pushed a commit that referenced this issue


          Nest and parallelise tests

df7abc6

[#4]

Signed-off-by: Jacques Chester <jchester@pivotal.io>

jchesterpivotal pushed a commit that referenced this issue


          Rename showjson.Show -> prettyjson.Prettify

495860b

Prefactoring in anticipation of shifting logic around.

[#4]

Signed-off-by: Jacques Chester <jchester@pivotal.io>

jchesterpivotal pushed a commit that referenced this issue


          Reinitialise gt variable in lower scope

17842b9

This is ugly and makes me sad and worried that I have overlooked
something obvious or fundamentally misunderstood something.

[#4]

Signed-off-by: Jacques Chester <jchester@pivotal.io>

jchesterpivotal pushed a commit that referenced this issue


          Backfill tests for show-build, show-plan, show-resource

041a6f5

Using a shared test, as these commands are almost identical.

[#4]

Signed-off-by: Jacques Chester <jchester@pivotal.io>

jchesterpivotal pushed a commit that referenced this issue


          Backfill prettyjson package tests

f7ac0b0

[#4]

Signed-off-by: Jacques Chester <jchester@pivotal.io>

jchesterpivotal pushed a commit that referenced this issue


          Provide basic protection against directory traversal

a3fd469

A better solution will be only allowing a single directory level and
hardcoding the file names, since the resource generates them. But
this commit at least provides a catch-all integration test.

[#4]

Signed-off-by: Jacques Chester <jchester@pivotal.io>

jchesterpivotal pushed a commit that referenced this issue


          Reject paths with filenames or nested directories

444724a

Intended to make traversal attacks harder.

[#4]

Signed-off-by: Jacques Chester <jchester@pivotal.io>

jchesterpivotal pushed a commit that referenced this issue


          Reject paths with filenames or nested directories

aca95c4

Intended to make traversal attacks harder.

[#4]

Signed-off-by: Jacques Chester <jchester@pivotal.io>

jchesterpivotal pushed a commit that referenced this issue


          Backfill tests for show-logs

9c768b1

- Add directory traversal guard logic

[#4]

Signed-off-by: Jacques Chester <jchester@pivotal.io>

jchesterpivotal pushed a commit that referenced this issue


          Fix missing show-logs entry in traversal tests

4de688c

Copying and pasting is hilarious.

[#4]

Signed-off-by: Jacques Chester <jchester@pivotal.io>

jchesterpivotal pushed a commit that referenced this issue


          Guard against encoding errors for cmd/{in,check}

151b924

[#4]

Signed-off-by: Jacques Chester <jchester@pivotal.io>

jchesterpivotal pushed a commit that referenced this issue


          Use log.Fatalf for brevity

ccaf35e

- Fix misleading error message (said 'in', should've been 'check')

[#4]

Signed-off-by: Jacques Chester <jchester@pivotal.io>

jchesterpivotal pushed a commit that referenced this issue


          Backfill tests for cmd/check

6cc1be6

[#4]

Signed-off-by: Jacques Chester <jchester@pivotal.io>

jchesterpivotal pushed a commit that referenced this issue


          Backfill tests for cmd/in

5ea4d59

[#4]

Signed-off-by: Jacques Chester <jchester@pivotal.io>

jchesterpivotal pushed a commit that referenced this issue


          Remove redundant nested if

6a564d3

[#4]

Signed-off-by: Jacques Chester <jchester@pivotal.io>

jchesterpivotal pushed a commit that referenced this issue


          Extract NewChecker() from Check()

fcd0ab4

A prefactoring to help testing pkg/check.

[#4]

Signed-off-by: Jacques Chester <jchester@pivotal.io>

jchesterpivotal pushed a commit that referenced this issue


          Introduce convenience variables

38fc5a9

[#4]

Signed-off-by: Jacques Chester <jchester@pivotal.io>

jchesterpivotal pushed a commit that referenced this issue


          Extract NewCheckerUsingClient() from NewChecker()

baff7a1

Another prefactoring to support test.

[#4]

Signed-off-by: Jacques Chester <jchester@pivotal.io>

jchesterpivotal pushed a commit that referenced this issue


          Make checker{} instance variables private

db84c25

[#4]

Signed-off-by: Jacques Chester <jchester@pivotal.io>

jchesterpivotal pushed a commit that referenced this issue


          Backfill pkg/check tests

bbc3538

- Fixed some bugs
  - Fixed for empty responses
  - Fixed for responses with no new versions
- Some changes to wording
- Add counterfeiter-generated fakes for go-concourse. Due to a known
  bug, I had to edit these manually to use a non-vendor import path
  in the generated code. See: maxbrunsfeld/counterfeiter#75

[#4]

Signed-off-by: Jacques Chester <jchester@pivotal.io>

jchesterpivotal pushed a commit that referenced this issue


          Push code up out of 'else' clause for simplicity

0043ef0

[#4]

Signed-off-by: Jacques Chester <jchester@pivotal.io>

jchesterpivotal pushed a commit that referenced this issue


          Extract getBuilds() from Check()

ee88f3a

[#4]

Signed-off-by: Jacques Chester <jchester@pivotal.io>

jchesterpivotal pushed a commit that referenced this issue


          Correct default page size to 50 builds

de95457

[#4]

Signed-off-by: Jacques Chester <jchester@pivotal.io>

jchesterpivotal pushed a commit that referenced this issue


          Extract NewInner(), NewInnerUsingClient() from In()

2c52314

Prefactoring to support testing. Same pattern as with pkg/check.

[#4]

Signed-off-by: Jacques Chester <jchester@pivotal.io>

jchesterpivotal pushed a commit that referenced this issue


          Fix copy-paste scar

53f0cb5

[#4]

Signed-off-by: Jacques Chester <jchester@pivotal.io>

jchesterpivotal pushed a commit that referenced this issue


          Backfill tests for pkg/in

87011ce

As with pkg/check, there are a few changes.

- Fixed trying to read error message from nil errors on 404s
- Some changes to wording
- Added counterfeiter-generated fakes for eventstream. Due to a known
  bug, I had to manually edit the fake file to use a non-vendor import
  path in the generated code. This also arose in bbc3538.
  See: See: maxbrunsfeld/counterfeiter#75

[#4]

Signed-off-by: Jacques Chester <jchester@pivotal.io>

jchesterpivotal pushed a commit that referenced this issue


          Guard against malformed JSON in pkg/in

01c8350

[#4]

Signed-off-by: Jacques Chester <jchester@pivotal.io>

jchesterpivotal pushed a commit that referenced this issue


          Spruce up: gofmt + rearrange imports

9ff3b11

[#4]

Signed-off-by: Jacques Chester <jchester@pivotal.io>

jchesterpivotal pushed a commit that referenced this issue


          Update README

cce4829

[Finishes #4]

Signed-off-by: Jacques Chester <jchester@pivotal.io>

jchesterpivotal closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment