Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to additional configuration of the main context #132

Merged
merged 1 commit into from
Nov 10, 2016

Conversation

realmyst
Copy link
Contributor

Now we can add more options to main config context, e.g.:

user www-data  www-data;
worker_processes  auto;
pid /var/run/nginx.pid;
worker_rlimit_nofile 1024;
include /etc/nginx/modules-enabled/*.conf; # extra option

http {
...
}

Copy link
Owner

@jdauphant jdauphant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the MR.
I have made one comment

@@ -34,6 +34,7 @@ nginx_worker_rlimit_nofile: 1024
nginx_log_dir: "/var/log/nginx"
nginx_error_log_level: "error"

nginx_extra_params: ""
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nginx_extra_params
Maybe we can make this more explicit like "nginx_extra_root_params" or "nginx_extra_top_params"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I agree that nginx_extra_root_params would be more explicit. Renamed it.

@jdauphant jdauphant merged commit c6f4f5f into jdauphant:master Nov 10, 2016
@jdauphant
Copy link
Owner

Merged and release in 2.4

@jdauphant
Copy link
Owner

jdauphant commented Nov 10, 2016

@realmyst I didn't see it before merging but could have been nice if it was a list instead of a single string attribute

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants