Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use with_dict instead of accessing keys from dict.keys() (#150) #153

Merged
merged 1 commit into from
Jan 20, 2017
Merged

use with_dict instead of accessing keys from dict.keys() (#150) #153

merged 1 commit into from
Jan 20, 2017

Conversation

tyxieblub
Copy link
Contributor

No description provided.

@jdauphant jdauphant merged commit 6a9ada3 into jdauphant:master Jan 20, 2017
@jdauphant
Copy link
Owner

Kudos for the work @tyxieblub !

@jdauphant
Copy link
Owner

@flatrocks take care of this change in your custom templates if you update to v2.7:

it may pose a problem for people with custom templates using these variables as they cannot access them with nginx_sites[item].var anymore and should now use item.value.var

@flatrocks
Copy link
Contributor

@jdauphant Thanks for the heads-up!
Urgent for me to get busy on that pull request for adding because also the readme Example 9 (custom templates) is incorrect, too!

@jdauphant
Copy link
Owner

@flatrocks Oh, thanks, I just fixed the readme.

@flatrocks
Copy link
Contributor

flatrocks commented Jan 20, 2017

My apologies @jdauphant for not getting to this sooner. I just posted pull request #155 to provide testing for custom templates, and further updated README to match the test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants