Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove default.conf in ubuntu16 #176

Closed
wants to merge 1 commit into from
Closed

Conversation

adamyala
Copy link

On ubuntu16, default is called default.conf. This PR adds default.conf to the list of default files to remove in the task Disable the default site

@adamyala
Copy link
Author

The error in travis is:

The command "ansible-playbook -i inventory --connection=local --sudo -vvvv test/test.yml -u root -e "role_name=ansible-role-nginx" -e "hosts_group=localhost" | grep -q 'changed=0.*failed=0' && (echo 'Idempotence test: pass' && exit 0) || (echo 'Idempotence test: fail' && exit 1)

Could I have some guidance as to what that means? I can go back in and fix it up.

@jdauphant
Copy link
Owner

@adamyala It's because the role create a "default.conf" by default:
https://github.com/jdauphant/ansible-role-nginx/blob/master/defaults/main.yml#L36
By removing this, the role isn't "Idempotence" anymore.

2 solutions:

  • Do nothing, the ubuntu "default.conf" will be replaced by the default one in this role
  • In this PR, change the default name here to somethings that don't conflict (but this can create confusion if someone want to create default.conf)

@adamyala
Copy link
Author

I decided to just add:

nginx_remove_sites: [default]

after the nginx_sites portion. Thank you for clarifying and thank you got continuing to maintain this role!

@adamyala adamyala closed this May 23, 2017
@jdauphant
Copy link
Owner

You're welcome :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants