Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept blocks on http params #183

Merged
merged 1 commit into from
Jan 4, 2018
Merged

Accept blocks on http params #183

merged 1 commit into from
Jan 4, 2018

Conversation

wvidana
Copy link
Contributor

@wvidana wvidana commented Aug 17, 2017

Problem: nginx blocks "{}" could not be used on nginx_http_params since
a semicolon will end up appended, making the configtest to fail

This solution also allows the use of the YAML pipe "|" that which appends a
new line add the end of the string

Problem: nginx blocks "{}" could not be used on nginx_http_params since
a semicolon will end up appended, making the configtest to fail

This solution also allows the use of the YAML pipe "|" that which appends a
new line add the end of the string
@jdauphant
Copy link
Owner

@woqer thanks for your help.
Sorry for the delay of anwser, I just come back from travel.
I have trouble to get into it, can you give me an example? (before/after)

@wvidana
Copy link
Contributor Author

wvidana commented Dec 22, 2017

Sorry for the late response, completely forgot about this.

What I meant to say is that, having a config like this one (with a block {}):

nginx_http_params:
      - here some { block; with; lines; }

The output is

BEFORE
        here some { block; with; lines; };
AFTER
        here some { block; with; lines; }

The trailing semicolon shouldn't be there after a block.

@jdauphant jdauphant merged commit 506e6bd into jdauphant:master Jan 4, 2018
@jdauphant
Copy link
Owner

@woqer Ok thanks for your help, sorry for the delay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants