Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to ansible 2.4 #188

Merged
merged 4 commits into from
Apr 5, 2018
Merged

Conversation

rhpvorderman
Copy link
Contributor

@rhpvorderman rhpvorderman commented Oct 13, 2017

@jdauphant
Copy link
Owner

@rhpvorderman Thanks, the PR is very good. You have sense of details, I love that ;)

I was thinking maybe we can wait the release of Ansible 2.5 before merging it so the project version will cover both version (I have seen some problems previously where people have to use previous version because of bugs or missing feature).
What do you thing?

@rhpvorderman
Copy link
Contributor Author

Sure. No need to rush the upgrade. Most people will not have updated their ansible yet. And include: still works. This pull request only fixes a deprecation warning on 2.4 and later.
It is all up to you when you want to get rid of those warnings ;-).

@nogweii
Copy link

nogweii commented Apr 4, 2018

Ansible 2.5 has been released, time to merge this?

@jdauphant
Copy link
Owner

@evaryont Yep !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants