Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow access rules to include in site configs #73

Closed
wants to merge 5 commits into from
Closed

Allow access rules to include in site configs #73

wants to merge 5 commits into from

Conversation

mightydok
Copy link

Hello.
I want to add support for custom access config files, like:

allow from 123.123.123.123
deny from all

I cant use nginx_configs section, because this type of config will be autoloaded at nginx restart and can broke access to web server, so i think i must add another section like nginx_auth_basic_files.
I change role, README and travis files.

@mightydok mightydok changed the title Fix for jdauphant/ansible-role-nginx#72 Allow access rules to include in site configs Nov 5, 2015
@jdauphant
Copy link
Owner

Hello @mightydok ,
Thanks for the pull request.
I am more in flavor to use ansible templating.
You have examples here:
https://github.com/jdauphant/ansible-role-nginx/releases/tag/v1.2
and more details here : #33

What do you think ?

Julien

@mightydok
Copy link
Author

Hello @jdauphant i think we need update README for that info. I will close pull request.

@mightydok mightydok closed this Nov 5, 2015
@mightydok mightydok deleted the access branch November 5, 2015 17:24
@jdauphant
Copy link
Owner

Yes, an update for the README cool be nice, we need to find good examples for that.

@mightydok
Copy link
Author

@jdauphant i think example with access rule, with just simple allow all; will suit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants