Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Vive La Mode as hard #1449

Merged
merged 2 commits into from
Dec 26, 2022
Merged

Add Vive La Mode as hard #1449

merged 2 commits into from
Dec 26, 2022

Conversation

thibautssss
Copy link
Contributor

No description provided.

@bogdan-the-great
Copy link
Contributor

In your place I would reread contributing guidlines again, and correct mistakes. I don't know if I can give You my advise, because I'm just a contributor.

tupaschoal
tupaschoal reviewed Dec 22, 2022
View reviewed changes
Copy link
Member

@tupaschoal tupaschoal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When support needs to be contacted, we put the difficulty as hard.

Aside from that, the entries on the JSON file are alphabetically ordered, so you need to move it further down. Let me know if you need help.

@tupaschoal tupaschoal changed the title Update sites.json Add Vive La Mode as hard Dec 26, 2022
tupaschoal
tupaschoal approved these changes Dec 26, 2022
View reviewed changes
Copy link
Member

@tupaschoal tupaschoal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have made the necessary changes to merge, but please keep the contributing guidelines in mind next time.

@tupaschoal tupaschoal merged commit ddad9f2 into jdm-contrib:master Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tupaschoal tupaschoal tupaschoal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thibautssss @bogdan-the-great @tupaschoal