Improve performance of lsp-mode or eglot using a wrapper executable.
(Huge thanks to @yyoncho for both maintaining lsp-mode and giving me the inspiration of this project).
According to yyoncho, the are several performance issues related to lsp-mode (mostly the same for elot):
- Json parsing in Emacs is slow
- The server may block on sending data to emacs when the buffer is full, because Emacs may consume the data too slo
- Similarly, Emacs may block on sending data to the server (hence block Emacs UI) when the buffer is full, because the server may be busy
@yyoncho tried to solve these issues by implementing native async non-blocking jsonrpc. The result is very good regarding performance. However it requires modifications in Emacs source code and it seems unlikely that those changes would be merged into upstream. Also, frankly I doubt that this would be well-maintained in the future since it also requires seperated code path in lsp-mode (I myself encountered some issues).
This project provides an wrapper executable around lsp servers to work around above-mentioned issues:
- It converts json responses from server into elisp bytecode (in text representation) for Emacs to read.
- e.g.
{"objs":[{"a":1},{"a":2}]}
would be converted to#[0 "\301\302\300\303D\300\304D\"D\207" [:a :objs vector 1 2] 13]
- This would improve the message parsing performance in Emacs by ~4x for large json objects, see benchmark result here
- Although Emacs still needs to parse the text representation and interpret it into elisp object, the performance gain mainly comes from:
- Parsing (
read
ing) elisp object is apparently better optimized and simpler in Emacs - Using bytecode to construct objects, we can eliminate duplicated objects (e.g. the "a" json key in above example)
- Parsing (
- e.g.
- It separates reading and writing into different threads and keeps pending messages in internal buffers, to avoid blocking on IO, which solves above-mentioned issue (2) and (3).
Overall, this achieves similar result as the native async non-blocking jsonrpc approach without requiring modifications in Emacs source code.
Generally, what you need to do is:
- Wrap your lsp server command with this
emacs-lsp-booster
executable. For example, if the original lsp server command ispyright-langserver --stdio
, configure lsp-mode or eglot to runemacs-lsp-booster pyright-langserver --stdio
instead. - Advise the json parsing function in lsp-mode or eglot to try to parse the input as bytecode instead of json.
See more detailed steps below.
For linux users, you may download the prebuilt binary from release. (The macOS binary in the release page lacks proper code signing for now.)
Or alternatively, you may build the target locally:
- Setup Rust toolchain
- Run
cargo build --release
- Find the built binary in
target/release/emacs-lsp-booster
Then, put the emacs-lsp-booster
binary in your $PATH (e.g. ~/.local/bin
).
(Make sure NOT to use the native-jsonrpc custom version)
- Use plist for deserialization for lsp-mode
- Add the following code to your
init.el
:
(defun lsp-booster--advice-json-parse (old-fn &rest args)
"Try to parse bytecode instead of json."
(or
(when (equal (following-char) ?#)
(let ((bytecode (read (current-buffer))))
(when (byte-code-function-p bytecode)
(funcall bytecode))))
(apply old-fn args)))
(advice-add (if (progn (require 'json)
(fboundp 'json-parse-buffer))
'json-parse-buffer
'json-read)
:around
#'lsp-booster--advice-json-parse)
(defun lsp-booster--advice-final-command (old-fn cmd &optional test?)
"Prepend emacs-lsp-booster command to lsp CMD."
(let ((orig-result (funcall old-fn cmd test?)))
(if (and (not test?) ;; for check lsp-server-present?
(not (file-remote-p default-directory)) ;; see lsp-resolve-final-command, it would add extra shell wrapper
lsp-use-plists
(not (functionp 'json-rpc-connection)) ;; native json-rpc
(executable-find "emacs-lsp-booster"))
(progn
(message "Using emacs-lsp-booster for %s!" orig-result)
(cons "emacs-lsp-booster" orig-result))
orig-result)))
(advice-add 'lsp-resolve-final-command :around #'lsp-booster--advice-final-command)
Done! Now try to use lsp-mode as usual.
Please see blahgeek#1 . Huge thanks to @jdtsmith
- Check that
emacs-lsp-booster
process is running - Check the stderr buffer (e.g. for lsp-mode,
*pyright::stderr*
buffer), it should containemacs_lsp_booster
related log.
Run emacs-lsp-booster --help
for more options.