Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically run testcrate in root tests #24

Merged
merged 2 commits into from
Dec 16, 2022
Merged

Conversation

jean-airoldie
Copy link
Owner

@jean-airoldie jean-airoldie commented Dec 16, 2022

It seems that if a git submodule is not properly initialize on the machine that will publish the crate, cargo won't warn or detect it, as described in this issue rust-lang/cargo#8635. This is hard to detect because the CI is setup to properly git clone --recursive and therefore should not detect this issue.

To reduce the likelyhood of #23 from happening again in the future, the testcrate was added as a dev-dedependecy to the root crate and the tests were moved to the root crate so that if cargo test is ran (even without the --workspace flag), the tests won't compile and the error should be detected.

@jean-airoldie jean-airoldie merged commit e7dd3b2 into master Dec 16, 2022
@jean-airoldie jean-airoldie deleted the fix_tests branch December 16, 2022 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant