fixed bug where respond_with was sending back improperly structured json

[ewpeters]

uploader.js was expecting a json response that looked like '{"image": "{..model attributes...}"}'. respond_with was sending '{.....model attributes.....}'

[jejacks0n]

Nice man.. so, two questions. The first, I understand that it's ok to remove the Mercury:: namespacing for the image model, but I've run into issues with that in the past -- eg. it thinks you want something that's namespaced deeper. Do you have any insight that I'm not aware of?

The second, is that I'm not seeing this.. is it a specific version of rails, or what?

I'd just like some clarification on those before I merge this.

Thanks again. =)

[ewpeters]

1. Oops, no insights, I am currently overriding the functionality in my project and it wasn't playing nice with the name spacing, so when I copy pasted it screwed up. I added a commit

2. I'm not sure, I'm running Rails 3.1.1 if that helps

[jejacks0n]

So this broke it for me -- and likely others who started with rails 3.1? Not fully sure, but we don't have something in our initializers that you have, and that's why this has been a bit confusing to me.

I tracked it down, and here are the details:

In this rails generator file, which is within railties 3.1.1 you can see that it sets ActiveRecord::Base.include_root_in_json to false.. That's not altogether bad, as it's system wide, but it's also not altogether good because it's system wide with no way to override it in a given scenario. So, yes, this is probably the root of the issue you're trying to solve, but this fix might not work for everyone. :-/

I'm rolling most of this back in a following commit and will add the logic to check the two places on the client.. unless you see a better way in rails? Besides telling people they should add ActiveRecord::Base.include_root_in_json = true to their initializers -- potentially breaking other aspects of their site.