Support assets not correctly prefixed by Embrodier with publicPath #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jelhan
requested changes
Feb 19, 2024
|
Done :) |
jelhan
approved these changes
Feb 19, 2024
jelhan
changed the title
|
Released as v0.2.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11
When
publicPathandrootURLare different<link>tags that are not stylesheets end up only using rootURL.This will allow the build to continue by handling this scenario.
Added test cases to account for that.
I also noticed the
adds crossorigin attribute to link elements for stylesheetstest was checking script tags 😅 so I've updated the default stylesheet tests so they only look at stylesheet<link>tags.