New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get popular people refactor #401

Merged

LordMike merged 1 commit into jellyfin:master from angyanmark:features/get-popular-people-refactor

Jan 9, 2023

Contributor

angyanmark commented Feb 17, 2022

There is no need for PersonListType.cs and PersonResult.cs.
Get popular people method renamed and language parameter added.

Now it matches the get popular movies and get popular tv shows methods, they all return a SearchContainer<SearchBase>.


          get popular people refactor

3f69191

Contributor Author

angyanmark commented Jan 4, 2023 •

edited

Loading

Could you take a look at this PR?

I changed the get popular people method's name and return value, now it is consistent with the other get popular methods (GetMoviePopularListAsync, GetTvShowPopularAsync).
I added the language parameter to the method.
I also removed the PersonResult class, it is the same as SearchPerson, and was only used here. Now all get popular methods return a SearchContainer<SearchBase>.

Thanks!

LordMike merged commit fe50e09 into jellyfin:master

angyanmark deleted the features/get-popular-people-refactor branch

January 11, 2023 14:56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment