-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Establishing the Development Workflow #15
Conversation
In case anyone is wondering, the similarities between this and Raanan Weber's BJS repository are intentional; the goal is to establish the foundation for building an ES6 web application using BJS, whereas Raanan's repository is oriented towards TypeScript |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better late than never ;-)
Just have a few comments, but it looks great.
Squashed Merge that includes these additions and changes * simplify .gitignore * Add common webpack config, placeholder dirs and files * Align approach with RW's TS approach. Fix scripts to use webpack configs * refactor webpack config, create canvas in index * including prod webpack config in updates * Adapt start scene snippet into Class * Capture camera, env into StartScene class * convert from class to component. Export createStartScene * Add landing page markup * Tweak landing page styles and markup * tweak CSS * remove source map from prod builds * remove devtool (sourcemap) option * Tighten up import statements to use tree-shaking Before: 8.91 MiB After: 3.11 MiB * Change to preview v5 of BJS packages
This PR adds basic repository content and configuration for the application.
-
npm run scripts
forstart
,build
, andlint
Opening PR now to allow early feedback