Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JENKINS-63727] Add support to convey compatibility info related to JGit and Git Publisher #615

Merged
merged 3 commits into from
Sep 22, 2020
Merged

[JENKINS-63727] Add support to convey compatibility info related to JGit and Git Publisher #615

merged 3 commits into from
Sep 22, 2020

Conversation

rishabhBudhouliya
Copy link
Contributor

@rishabhBudhouliya rishabhBudhouliya commented Sep 21, 2020 •
edited by MarkEWaite
Loading

JENKINS-63727 - Add support to convey compatibility info related to JGit and Git Publisher

The UnsupportedCommand now features a support to convey if JGit should be suggested
as a viable implementation in the scenario where Git Publisher is added as a post build
action.

Checklist

  • I have read the CONTRIBUTING doc
  • I have referenced the Jira issue related to my changes in one or more commit messages
  • I have added tests that verify my changes
  • Unit tests pass locally with my changes
  • I have added documentation as necessary
  • No Javadoc warnings were introduced with my changes
  • No spotbugs warnings were introduced with my changes
  • I have interactively tested my changes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

@rishabhBudhouliya
Add support to convey compatibility info related to JGit and Git Publ…
5c22b66 
…isher

The UnsupportedCommand now features a support to convey if JGit should be suggested
as a viable implementation in the scenario where Git Publisher is added as a post build
action.
@rishabhBudhouliya rishabhBudhouliya mentioned this pull request Sep 21, 2020
Merged
11 tasks
MarkEWaite
MarkEWaite requested changes Sep 21, 2020
View reviewed changes
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs Javadoc to avoid a pair of Javadoc warnings.

Also needs tests to check the new public method.

src/main/java/org/jenkinsci/plugins/gitclient/UnsupportedCommand.java Outdated Show resolved Hide resolved
@MarkEWaite MarkEWaite merged commit b85fc89 into jenkinsci:master Sep 22, 2020
@rishabhBudhouliya
Copy link
Contributor Author

@MarkEWaite Apologies for not being able to add your suggestions in due time, many thanks for doing so!

@MarkEWaite MarkEWaite added bug Incorrect or flawed behavior and removed bugfix labels Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkEWaite MarkEWaite MarkEWaite approved these changes

Assignees
No one assigned
Labels
bug Incorrect or flawed behavior
Projects
None yet
Milestone
No milestone
2 participants
@rishabhBudhouliya @MarkEWaite