Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw GitException as expected in GitClientTest #618

Merged

Conversation

MarkEWaite
Copy link
Contributor

Throw GitException as expected in GitClientTest

When command line git does not support remote symbolic references, the test intentionally exits early. In order to pass the test, it needs to throw the expected exception instead of simply returning. Throw the
expected exception.

Allows tests to run successfully on CentOS 7 with git 1.8.3.

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that verify my changes
  • Unit tests pass locally with my changes
  • I have added documentation as necessary
  • No Javadoc warnings were introduced with my changes
  • No spotbugs warnings were introduced with my changes

Types of changes

  • Tests

When command line git does not support remote symbolic references, the
test intentionally exits early.  In order to pass the test, it needs
to throw the expected exception instead of simply returning. Throw the
expected exception.

Allows tests to run successfully on CentOS 7 with git 1.8.3.
@MarkEWaite MarkEWaite added the test Automated test addition or improvement label Sep 26, 2020
@MarkEWaite MarkEWaite merged commit af2f941 into jenkinsci:master Sep 27, 2020
@MarkEWaite MarkEWaite deleted the throw-exception-on-test-exit branch September 27, 2020 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Automated test addition or improvement
Projects
None yet
1 participant