Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: cleanup unused code #494

Merged
merged 15 commits into from
Apr 8, 2023
Merged

chore: cleanup unused code #494

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
e6a385d
.'
naorpeled Apr 8, 2023
32cec9d
.
naorpeled Apr 8, 2023
a3fcc6a
.
naorpeled Apr 8, 2023
bb9c76f
.
naorpeled Apr 8, 2023
91ef283
.
naorpeled Apr 8, 2023
2fb93b4
.
naorpeled Apr 8, 2023
9f2bdc1
.
naorpeled Apr 8, 2023
aed88da
.
naorpeled Apr 8, 2023
e04885e
.
naorpeled Apr 8, 2023
2635ad5
.
naorpeled Apr 8, 2023
0a4a32a
.
naorpeled Apr 8, 2023
1fa39a8
.
naorpeled Apr 8, 2023
49023ec
.
naorpeled Apr 8, 2023
4f007a1
.
naorpeled Apr 8, 2023
f157f71
.
naorpeled Apr 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
.
  • Loading branch information
@naorpeled
naorpeled committed Apr 8, 2023
commit 1fa39a880efde4c9a0a9f4a0963d81f04f3199a9
28 changes: 16 additions & 12 deletions src/__tests__/table.batchWrite.unit.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { BatchWriteCommandInput } from '@aws-sdk/lib-dynamodb'
import { Entity, Table } from '../index'
import { DocumentClient as docClient } from './bootstrap.test'
import assert from 'assert'

const TestTable = new Table({
name: 'test-table',
Expand Down Expand Up @@ -40,9 +41,11 @@ describe('batchWrite', () => {
const result = TestTable.batchWriteParams(
TestEntity.putBatch({ email: 'test', sort: 'testsk', test: 'test' })
) as BatchWriteCommandInput
expect(result.RequestItems!['test-table']![0]!.PutRequest!.Item!.pk).toBe('test')
expect(result.RequestItems!['test-table']![0]!.PutRequest!.Item!.sk).toBe('testsk')
expect(result.RequestItems!['test-table']![0]!.PutRequest!.Item!.test).toBe('test')

assert.ok(result?.RequestItems?.['test-table']?.[0]?.PutRequest?.Item !== undefined, 'PutRequest.Item is undefined')
expect(result.RequestItems['test-table'][0].PutRequest.Item.pk).toBe('test')
expect(result.RequestItems['test-table'][0].PutRequest.Item.sk).toBe('testsk')
expect(result.RequestItems['test-table'][0].PutRequest.Item.test).toBe('test')
})

it('fails when extra options', () => {
Expand Down Expand Up @@ -82,7 +85,8 @@ describe('batchWrite', () => {

expect(result.ReturnConsumedCapacity).toBe('TOTAL')
expect(result.ReturnItemCollectionMetrics).toBe('SIZE')
expect(result.RequestItems!['test-table']![0]!.PutRequest!.Item).toEqual(expect.objectContaining({

expect(result.RequestItems?.['test-table']?.[0]?.PutRequest?.Item).toEqual(expect.objectContaining({
pk: 'test',
sk: 'testsk',
test: 'test'
Expand All @@ -97,7 +101,7 @@ describe('batchWrite', () => {
'test'
) as BatchWriteCommandInput

expect(result.RequestItems!['test-table'][0].PutRequest!.Item).toEqual(expect.objectContaining({
expect(result.RequestItems?.['test-table']?.[0]?.PutRequest?.Item).toEqual(expect.objectContaining({
pk: 'test',
sk: 'testsk',
test: 'test'
Expand All @@ -113,7 +117,7 @@ describe('batchWrite', () => {
) as { payload: BatchWriteCommandInput; Tables: any }

expect(result).toHaveProperty('Tables')
expect(result.payload.RequestItems!['test-table'][0].PutRequest!.Item).toEqual(expect.objectContaining({
expect(result.payload.RequestItems?.['test-table']?.[0]?.PutRequest?.Item).toEqual(expect.objectContaining({
pk: 'test',
sk: 'testsk',
test: 'test'
Expand All @@ -127,17 +131,17 @@ describe('batchWrite', () => {
TestEntity.deleteBatch({ email: 'test', sort: 'testsk3' })
]) as BatchWriteCommandInput

expect(result.RequestItems!['test-table']![0].PutRequest!.Item).toEqual(expect.objectContaining({
expect(result.RequestItems?.['test-table']?.[0]?.PutRequest?.Item).toEqual(expect.objectContaining({
pk: 'test',
sk: 'testsk1',
test: 'test1'
}))
expect(result.RequestItems!['test-table']![1].PutRequest!.Item).toEqual(expect.objectContaining({
expect(result.RequestItems?.['test-table']?.[1]?.PutRequest?.Item).toEqual(expect.objectContaining({
pk: 'test',
sk: 'testsk2',
test: 'test2'
}))
expect(result.RequestItems!['test-table']![2].DeleteRequest!.Key).toEqual(expect.objectContaining({
expect(result.RequestItems?.['test-table']?.[2]?.DeleteRequest?.Key).toEqual(expect.objectContaining({
pk: 'test',
sk: 'testsk3'
}))
Expand Down Expand Up @@ -170,17 +174,17 @@ describe('batchWrite', () => {
TestEntity2.putBatch({ email: 'test', sort: 'testsk3', test: 'test3' })
]) as BatchWriteCommandInput

expect(result.RequestItems!['test-table']![0]!.PutRequest!.Item).toEqual(expect.objectContaining({
expect(result.RequestItems?.['test-table']?.[0]?.PutRequest?.Item).toEqual(expect.objectContaining({
pk: 'test',
sk: 'testsk1',
test: 'test1'
}))
expect(result.RequestItems!['test-table']![1]!.PutRequest!.Item).toEqual(expect.objectContaining({
expect(result.RequestItems?.['test-table']?.[1]?.PutRequest?.Item).toEqual(expect.objectContaining({
pk: 'test',
sk: 'testsk2',
test: 'test2'
}))
expect(result.RequestItems!['test-table2']![0]!.PutRequest!.Item).toEqual(expect.objectContaining({
expect(result.RequestItems?.['test-table2']?.[0]?.PutRequest?.Item).toEqual(expect.objectContaining({
pk: 'test',
sk: 'testsk3',
test: 'test3'
Expand Down