Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(package.json): improve dependency declaration #506

Merged
merged 1 commit into from
Apr 14, 2023

Conversation

NimmLor
Copy link
Contributor

@NimmLor NimmLor commented Apr 13, 2023

  • add @aws-sdk/util-dynamodb as devDependency
  • add @aws-sdk/lib-dynamodb and @aws-sdk/client-dynamodb as peerDependencies

The added peerDependencies will at least print out a warning if user hasn't installed them yet.

warning " > dynamodb-toolbox@0.8.2" has unmet peer dependency "@aws-sdk/lib-dynamodb@^3.0.0".
warning " > dynamodb-toolbox@0.8.2" has unmet peer dependency "@aws-sdk/client-dynamodb@^3.0.0".

@naorpeled
Copy link
Collaborator

LGTM!!

@naorpeled naorpeled merged commit 8aca594 into jeremydaly:main Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants