Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: dual module export #607

Merged
merged 10 commits into from
Oct 18, 2023
Merged

feat: dual module export #607

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
bef4513
feat: update package.json and tsconfig to support dual module output
antstanley Oct 18, 2023
045d70c
chore: update files prop to include dual modules
antstanley Oct 18, 2023
8fd1878
chore: update index.test-d.ts to reference new output location
antstanley Oct 18, 2023
a1f146a
feat: distinct cjs and esm tsconfig
antstanley Oct 18, 2023
9e8abf1
feat: update import extensions to use .js
antstanley Oct 18, 2023
f7f06aa
fix: add module declaration for 'deep-copy'
antstanley Oct 18, 2023
a950016
feat: update tests to use .js imports, and update jest config for esm
antstanley Oct 18, 2023
b74fd58
fix: update extensions on missing files
antstanley Oct 18, 2023
b8e90ce
feat: update type tests to include esm and cjs types
antstanley Oct 18, 2023
30e44ba
chore: remove old single export type test
antstanley Oct 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feat: distinct cjs and esm tsconfig
  • Loading branch information
@antstanley
antstanley committed Oct 18, 2023
commit a1f146ab6e3afed1ebbc7cb148fa86baba7397ae
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"test-types": "tsd",
"check-types": "tsc --noEmit",
"lint": "eslint .",
"build:cjs": "tsc -p tsconfig.build.json && echo '{ \"type\": \"commonjs\" }' > dist/cjs/package.json",
"build:cjs": "tsc -p tsconfig.cjs.json && echo '{ \"type\": \"commonjs\" }' > dist/cjs/package.json",
"build:esm": "tsc -p tsconfig.esm.json && echo '{ \"type\": \"module\" }' > dist/esm/package.json",
"build": "npm run build:cjs & npm run build:esm",
"prebuild": "rm -rf dist",
Expand Down
2 changes: 2 additions & 0 deletions tsconfig.build.json → tsconfig.cjs.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
{
"extends": "./tsconfig.json",
"compilerOptions": {
"moduleResolution": "node",
"module": "commonjs",
"outDir": "dist/cjs"
},
"exclude": ["node_modules", "dist", "**/*.test.ts", "**/*.test-d.ts"]
Expand Down
4 changes: 2 additions & 2 deletions tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
{
"compilerOptions": {
"module": "NodeNext",
"moduleResolution": "NodeNext",
"baseUrl": "src",
"target": "es2019",
"rootDir": "src",
"moduleResolution": "node",
"module": "commonjs",
"declaration": true,
"inlineSourceMap": false,
"esModuleInterop": true /* Enables emit interoperability between CommonJS and ES Modules via creation of namespace objects for all imports. Implies 'allowSyntheticDefaultImports'. */,
Expand Down