fix: add dist package.json to files #619
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node.js uses either file extensions or the
"type"
field inpackage.json
to determine if files are CommonJS or ES Module files. When we shipped dual module support,package.json
files were placed in bothdist/esm
anddist/cjs
with the correct"type"
property. This would enable consumers of the library to correctly interpret what type of module system the files were using.The problem is that we did not add these
dist
specific subpackage.json
files to thefiles
property of the rootpackage.json
so they were never published. This led to Node assuming all files were ESM, even the ones indist/cjs
.This leads to errors for folks trying to use CommonJs. This PR adds those files into the
files
property to resolve this issue.Resolves #615