feat: Add "properties.security-severity" to SARIF report be able to filter and sort by Severity in GitHub Security Code scanning #5227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t by Severity in GitHub Security Code scanning. Co-authored-by: Michael Blume <michael.blume@otto.de>
nhumblot
approved these changes
Jan 6, 2023
aikebah
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Actually, all issues have the same Severity in the Security Code scanning overview.
As described here it's possible/recommended to add a severity with the
properties.security-severity.So we added the "properties.security-severity" to the SARIF template to be able to filter and sort by Severity in GitHub Security Code scanning.
We think, that the base score described here, should have the correct value.
Have test cases been added to cover the new functionality?
no - but I uploaded the generated SARIF file and verified, that the file could be processed by GitHub and I could filter and sort in the Security Code scanning overview.