fix: name calculation #5266
Merged
fix: name calculation #5266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue
Description of Change
The current name calculation just looks for the last occurence of the string "node_modules" and calculates a substring after the occurence plus 1 arbitrary additional character. However, if this string is used as part of the package name the calculation ist wrong and the dependency check crashes with:
"Could not perform Node Audit analysis. Invalid payload submitted to Node Audit API".
We ran into this problem as we updated to the latest gradle plugin version due to #5220 and having "node_modules-path" as a transitive dependency.
I added the slash to the indexOf check to ensure the right pattern is matched.
Have test cases been added to cover the new functionality?
no