Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Hint Analyzer should run before VersionFilter Analyzer #5818

Merged
merged 2 commits into from
Aug 19, 2023
Merged

fix: Hint Analyzer should run before VersionFilter Analyzer #5818

merged 2 commits into from
Aug 19, 2023

Commits on Aug 19, 2023

  1. Fixup the sequence of analyzers to resolve #5812. 

    Ensure that HintAnalyzer runs before VersionFilterAnalyzer as HintAnalyzer may add versions that are not yet present in the evidences. VersionFilterAnalyzer may otherwise wrongly set an explicit version for the dependency if the collected evidences converge to a single version but the hints add a new and different version.

Also add an implementation note on the AnalysisPhase to document which analyzers are bound to which phase.

Introduces 2 additional POST_INFORMATION_COLLECTION phases so that DependencyMergingAnalyzer is guaranteed to run before HintAnalyzer which in its turn is guaranteed to run before VersionFilterAnalyzer
    @aikebah @jeremylong
    aikebah authored and jeremylong committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    a565f4a View commit details
    Browse the repository at this point in the history

  2. Fixup the logger of NpmCPEAnalyzer to refer to the proper class

    @aikebah @jeremylong
    aikebah authored and jeremylong committed Aug 19, 2023
    Configuration menu
    Copy the full SHA
    d2f02a8 View commit details
    Browse the repository at this point in the history